uMod - Threshold explanation? - Steam Checks

Posted 5 years ago

Last updated 5 years ago

Hi guys,

can you help me understanding the threshold part in the configuration?

In this case,

  "Thresholds": {
    "VacBan": 1,
    "GameBan": 1,
    "RecentBan": 1,
    "HoursPlayed": 0,
    "GameCount": 1
  },

what exactly do the numbers mean? Does a player with 1 VAC ban get kicked or can a player with 1 VAC still join the server? What is threshold for kicking anyone with VAC?

Posted 5 years ago

I'm not that familiar with the current code, but I would assume those are the amounts that it checks for to take action. Any check with that amount or higher would have action taken.

Posted 5 years ago

yeah I thought so, yet it's not working properly. Some people with 1 VAC or game ban can still join. I have a feeling that this plugin is not working properly, because I don't even see the steam check in console for every player join - only at some.

Posted 5 years ago

Last updated 5 years ago

I was looking into the Source Code. It indeed is really a threshold.

So when you set thresholdVacBan to 1, it means, that it bans user which have 2 VAC Bans or more. So you have to set it to 0, if you dont want any VAC bans.
GameCount is similar, if thresholdGameCount is 2, it will kick people, which only have 1 game.

The Plugin is really Spaghetti-Code. It probably has to be rewritten.

Posted 5 years ago

Sapd
The Plugin is really Spaghetti-Code. It probably has to be rewritten.

Slated to be, just haven't had time since talking it over as maintainer.

Posted 5 years ago

Last updated 5 years ago

I've done the work and did a complete rewrite from scratch.

Main differences:
- Game count can be checked even when user has this information hidden (done via badges)
- Steam level can be checked
- Hourchecks can be configured in a way, to only kick when user has shown this information
- Because Steam now hides that on default settings
- Steam account age can be checked
- Whitelist via permissions
- Caching
- Unit-like tests for every function, via CMD
- Cleaner code
- Would be even better, when webrequest.Enqueue had an async/await variant. Since I could then avoid nesting callbacks.

Will test it in production this weekend on my public server, and submit it after this weekend to umod.

Posted 5 years ago

Last updated 5 years ago

Sapd
@Wulf
I've done the work and did a complete rewrite from scratch.

If you want to take over the plugin you can, no need for another version. In that case, I would just call it Steam Checks.

Posted 5 years ago

Last updated 5 years ago

Wulf
If you want to take over the plugin you can, no need for another version. In that case, I would just call it Steam Checks.

Sure, I will rename it then/keep the name Steamchecks and give it a new major version.