High amount of held entities
So you claim "ITS DEFINETLY IT"(sic) regarding SkinBox but you don't actually know? The test is simple, count held entities, use SkinBox, recount held entities.

If you actually test it instead of just guessing you would see that no entities are leaked, the code you posted even confirms that just by looking at the end of DoRemove where it has a null check for the held entity and logs a warning if it still exists so I refer you back to my previous statement of don't talk shit.

It would have taken you 2 minutes to work out if what you were assuming was actually true, but instead for what ever reason you decided to peddle your assumption as a fact and then argued your point. Don't be that guy
The weapon mods are created by Kits and Orange was informed months ago. Orange needs to stop blaming others for his failures!

Merged post

foreach (var mod in mods)
{
    BuildItem(mod, 1, 0, 0).MoveToContainer(item.contents); //Added - creates one
    //item.contents.AddItem(BuildItem(mod, 1, 0, 0).info, 1); //Removed - creates two items, moves one.
}​
5d72c049357bb.png MikeHawke
The weapon mods are created by Kits and Orange was informed months ago. Orange needs to stop blaming others for his failures!

Merged post

foreach (var mod in mods)
{
    BuildItem(mod, 1, 0, 0).MoveToContainer(item.contents); //Added - creates one
    //item.contents.AddItem(BuildItem(mod, 1, 0, 0).info, 1); //Removed - creates two items, moves one.
}​

My failures? What? Where?

That fix that I posted was sent to you months ago... and you ignored it! Thats why users had 30k weapon mods etc from your code. You dropped the plugin and didnt fix the issue... just chose to blame everyone else when you are the one that turned the blind eye causing users to find fixes elswhere!
Is this the fix yes?
5d72c049357bb.png MikeHawke
The weapon mods are created by Kits and Orange was informed months ago. Orange needs to stop blaming others for his failures!

Merged post

foreach (var mod in mods)
{
    BuildItem(mod, 1, 0, 0).MoveToContainer(item.contents); //Added - creates one
    //item.contents.AddItem(BuildItem(mod, 1, 0, 0).info, 1); //Removed - creates two items, moves one.
}​​
We edit this line in Kits.cs and then it's fixed? It's that easy yes? And people have known for months?

I literally had 50k weapon attachments in my server and it's this line and people known for months reeeee

thanks alot this is a huge lifesaver, I hope everything is fixed now.

Can I just add attachments in my kits now without worries? No matter if they are already on the gun or in inventories or in auto kits etc?
I dont care if its kits or skinbox (not balmeing either) but can someone PM me on discord a "fixed" version. Discord: Razor14150#7265 I litterally have to run the item cleaner every few days because if not the entity count rockets.
Razor14150
I dont care if its kits or skinbox (not balmeing either) but can someone PM me on discord a "fixed" version. Discord: Razor14150#7265 I litterally have to run the item cleaner every few days because if not the entity count rockets.

the fix above your post has worked for me, it is Kits.cs

5d72c049357bb.png MikeHawke
That fix that I posted was sent to you months ago... and you ignored it! Thats why users had 30k weapon mods etc from your code. You dropped the plugin and didnt fix the issue... just chose to blame everyone else when you are the one that turned the blind eye causing users to find fixes elswhere!

Lol? Where? Where? Drop the changed code here. Because there are no issues with my kits

Codes been dropped here (Scroll back)... and testamonies that it fixed the issue... Was live on discords that you were members of for months and has been sent to you personally, you chose to ignore it! Actions speak louder then words Orange!

Issues were with your code.. you blame other people. People show you the problem with your code... you refuse to acknowledge it.

Deflate your ego a bit because your not coming across as a good developer your coming across as an arrogant one. 

Which ultimatley will cost you more business then it will earn you!

And when you say "My kits" we are refering to the free version that you maintened not your pay for version.

5d72c049357bb.png MikeHawke

Codes been dropped here (Scroll back)... and testamonies that it fixed the issue... Was live on discords that you were members of for months and has been sent to you personally, you chose to ignore it! Actions speak louder then words Orange!

Issues were with your code.. you blame other people. People show you the problem with your code... you refuse to acknowledge it.

Deflate your ego a bit because your not coming across as a good developer your coming across as an arrogant one. 

Which ultimatley will cost you more business then it will earn you!

And when you say "My kits" we are refering to the free version that you maintened not your pay for version.

Talking about free one i am maintained a bit and telling me that i made mistake in it, lol

I'll decode that into english first then....

You maintened it AND REFUSED TO LISTEN TO PEOPLE WHEN THEY INFORMED YOU THERE WAS A FAULT!

How hard is that to get into your head Orange.... Let me say it loudly and clearly....... *Clears throat*

YOU REFUSED TO ACKNOWLADE THE ISSUE AND BLAMED OTHER PEOPLES PLUGINS FOR YOUR INCOMPETENCE!

 

Wow this is fucked up beyond reason any way I look at it...

PD: Thanks for the fix I also suffered this problem and have patched my kits.cs
This version of kits should be changed to "broken" for anyones sake untill someone replaces it with the fixed version.

Tens of thousands of invisible entities is a game-breaking issue and it pains me knowing i've been struggling with it for months when the cause was unknown on umod for so long.
Goldie
This version of kits should be changed to "broken" for anyones sake untill someone replaces it with the fixed version.

Tens of thousands of invisible entities is a game-breaking issue and it pains me knowing i've been struggling with it for months when the cause was unknown on umod for so long.

So yeah we know we have useless entities on server but does it actually cause any issues? I didn't notice any issues on my servers...

miesku

So yeah we know we have useless entities on server but does it actually cause any issues? I didn't notice any issues on my servers...

From server load time to lag spikes. More entities - more freezes with plugins that checks entities, etc. Plus god knows how it works, but there are huge lag spikes at 0 0 0, because there are a lot of entities (basic position)