Kleementin

No. You were meant. Cause youre the only one that updates the plugin even though youre not a programmer. :) Good job.

Oh... Actually I am literally doing nothing but applying the suggestions that someone else is giving me. Crushed told me what to apply and where in this postand I just did it. So maybe it's him that is way more entitled to take over this good plugin... ;-) 

Crushed

Greetings.
As i saw some people asking for it , but with no definite answer - Here's the answer how to display the "new" scientist npcs if they get killed

Just replace this 

// Ignore deaths of other entities
            if (data.KillerEntityType == CombatEntityType.Other || data.VictimEntityType == CombatEntityType.Other)
		return;

With this - 

// Ignore deaths of other entities
            if (data.KillerEntityType == CombatEntityType.Other || data.VictimEntityType == CombatEntityType.Other)
			{
				var enemy = data.VictimEntity?.GetType().Name ?? "NULL";
				if(enemy != "ScientistNPC")
				{
					return;
				}
				
			}

That should do the trick

//  You MIGHT have to add the messages into the config after that.  the Victim type is "Other"

I've applied this, it now works but it just not that perfect yet. Hopefully a proper rework will be done. :) Thanks for those who help out.

Crushed

Greetings.
As i saw some people asking for it , but with no definite answer - Here's the answer how to display the "new" scientist npcs if they get killed

Just replace this 

// Ignore deaths of other entities
            if (data.KillerEntityType == CombatEntityType.Other || data.VictimEntityType == CombatEntityType.Other)
		return;

With this - 

// Ignore deaths of other entities
            if (data.KillerEntityType == CombatEntityType.Other || data.VictimEntityType == CombatEntityType.Other)
			{
				var enemy = data.VictimEntity?.GetType().Name ?? "NULL";
				if(enemy != "ScientistNPC")
				{
					return;
				}
				
			}

That should do the trick

//  You MIGHT have to add the messages into the config after that.  the Victim type is "Other"

Is this still working for anyone? I just tested this on oil rig scientists to no avail.

Whispers88

Scarecrows are not registered as a victim type and they are not NPCs so you won't see them being recorded in death notes.