So back when I had to upgrade from 2.0.4 to 3.x.x the items moved from the config file to a data file which was formatted differently, like:
{
"ItemId": -363689972,
"Shortname": "whatever",
"HasDurability": true,
"VanillaStackSize": 1,
"CustomStackSize": 3000
},
..... etc
It was a real pain and took me over an hour to convert painstakingly by hand to get it working properly again.
Now that 3.4.3 to 4.0.0 you are now getting rid of the data file and moving it all back into the config file under the "IndividualItemStackSize".. which was like the old version 2.x.x. The data file I converted is now useless and for it to work with the 4.0.0 version I now need to convert it all back into the single-line entries in the config file, like it used to be in the old 2.x.x
Faced with the amount of work that will require, and noticing that once again the plugin does not convert the old file to a new one, and the fact it is christmas weekend I really couldn't be stuffed so I rolled back to 3.4.3.
Now don't get me wrong, I really do appreciate the work you have done and the contribution you have made to the community in the form of this free plugin but you can understand my frustration as I am faced with basically the same job again but in reverse.. Unless I am missing something?
Config broken.. againSuggestion
Oh no I fully understand. I not so fondly remember being annoyed as hell having to set stack sizes frequently due to one issue or another in the early days. Wasn't a whole lot I could do. The code necessary for stacksize migration from one format to another would take more effort than the update to 4.0 for one off functionality that'd need to be trimmed out later. v4 wouldn't even really be necessary if people read the plugin description and utilized a little common sense, however that supply was as limited as toilet paper during the first year of the pandemic. (IE: not there)
Additionally to be fair if you were an early adopter then you haven't had to set these stack sizes for a year, so that's not so bad.
If you want to save some time, I may have a method, not totally sure if it'd work however.
- Keep v3 loaded with your stack sizes.
- Download v4 and modify line 41 to be "//DownloadVanillaDefaults();" instead of "DownloadVanillaDefaults();" (This prevents this functionality from executing.)
- While v3 is still loded, overwrite it with the modified v4.
- Once loaded immediately run the command "stacksizecontroller.vd" which will generate the vanilla defaults file from current stack sizes. I created this for my use.
- Copy the contents of the vanilla-defaults.json datafile everything except open and closing brackets "{" and "}" and paste those values into the configuration file in IndividualItemStackSize.
- Then overwrite the modified v4 plugin with the original and reload the plugin.
- Hopefully profit?
Personally i can never understand the angst from server owners who find they have to edit a large file, it took me just under an hour to edit the whole thing, and i probably wont have to do it again unless there is another change back to data file system.
You have the same problem with BetterLoot and other large configuration plugins, you just have to bite the bullet and get it done.
Man even with that one plugin like betterloot with the really nice editor, it's a huge pain in the ass. I honestly just accepted that, and the many other stupidities of running a server as a part of running a decent server. It's certainly a time investment lol
AnExiledDev
Oh no I fully understand. I not so fondly remember being annoyed as hell having to set stack sizes frequently due to one issue or another in the early days. Wasn't a whole lot I could do. The code necessary for stacksize migration from one format to another would take more effort than the update to 4.0 for one off functionality that'd need to be trimmed out later. v4 wouldn't even really be necessary if people read the plugin description and utilized a little common sense, however that supply was as limited as toilet paper during the first year of the pandemic. (IE: not there)
Additionally to be fair if you were an early adopter then you haven't had to set these stack sizes for a year, so that's not so bad.
If you want to save some time, I may have a method, not totally sure if it'd work however.If that doesn't work I can see about an independent converter but my time is once again extremely limited, but things might be less of a hellscape for me in January and it's possible you'll see something then, hopefully.
- Keep v3 loaded with your stack sizes.
- Download v4 and modify line 41 to be "//DownloadVanillaDefaults();" instead of "DownloadVanillaDefaults();" (This prevents this functionality from executing.)
- While v3 is still loded, overwrite it with the modified v4.
- Once loaded immediately run the command "stacksizecontroller.vd" which will generate the vanilla defaults file from current stack sizes. I created this for my use.
- Copy the contents of the vanilla-defaults.json datafile everything except open and closing brackets "{" and "}" and paste those values into the configuration file in IndividualItemStackSize.
- Then overwrite the modified v4 plugin with the original and reload the plugin.
- Hopefully profit?
Unfortunately that didn't work. It just copied the vanilla defaults from the previous config, my old config doesn't use vanilla defaults it uses the custom stack sizes. I will manually convert again next week sometime.
Thanks for your understanding response though and yes, I was a bit late to the party for the v3 upgrade but that was because I was putting off the upgrade from 2.x.x for the same reason. It just feels a bit like I "just finished manually converting the config file from the previous major version and now I have to do it again" but yeah I know - that is my fault for leaving it so late so in hindsight I'm sorry I vented a bit in my original post, you give this plugin to the community for free afterall. Thank you.
Not so much angst that is probably an exaggeration but yeah I get the point. Indeed sometimes we do "just have to bite the bullet and get it done" being a server owner. This month was a killer with the AI update, it broke so many things. I had recently spent almost a day updating, fixing and reconfiguring the huge pile of plugins that got broken from that.pookins
Personally i can never understand the angst from server owners who find they have to edit a large file, it took me just under an hour to edit the whole thing, and i probably wont have to do it again unless there is another change back to data file system.
You have the same problem with BetterLoot and other large configuration plugins, you just have to bite the bullet and get it done.
Yes I know we were all in the same boat there too and with so many plugins running on my server (109) I have dug the hole very deep there for myself, moreso than most other server owners that run and have to maintain much less.
AnExiledDev
Man even with that one plugin like betterloot with the really nice editor, it's a huge pain in the ass. I honestly just accepted that, and the many other stupidities of running a server as a part of running a decent server. It's certainly a time investment lol
I have never used "the really nice editor" i always use the same system for large edits, I copy the config to a "new text file"
and edit it to what i want then validate it, then unload plugin (if its a data file) and copy/paste the new edit to replace the old one, my server host has a page time limit which does not give enough time to edit a large file so its easier that way, and it also gives me a copy of the config to re-edit if needed.
I only run 92 plugins but the bot plugin was replaced with a new version which had many issues with the FP chaos,
deano79Unfortunately that didn't work. It just copied the vanilla defaults from the previous config, my old config doesn't use vanilla defaults it uses the custom stack sizes. I will manually convert again next week sometime.
Not so much angst that is probably an exaggeration but yeah I get the point. Indeed sometimes we do "just have to bite the bullet and get it done" being a server owner. This month was a killer with the AI update, it broke so many things. I had recently spent almost a day updating, fixing and reconfiguring the huge pile of plugins that got broken from that.
Thanks for your understanding response though and yes, I was a bit late to the party for the v3 upgrade but that was because I was putting off the upgrade from 2.x.x for the same reason. It just feels a bit like I "just finished manually converting the config file from the previous major version and now I have to do it again" but yeah I know - that is my fault for leaving it so late so in hindsight I'm sorry I vented a bit in my original post, you give this plugin to the community for free afterall. Thank you.
Yes I know we were all in the same boat there too and with so many plugins running on my server (109) I have dug the hole very deep there for myself, moreso than most other server owners that run and have to maintain much less.
"It just copied the vanilla defaults from the previous config" - Are they actually vanilla defaults, or are they actually your stack sizes. No one uses vanilla-defaults (unless they're using the plugin incorrectly) it's there for reverting stack sizes. Just double check they're actually the vanilla stacks not modified. If it is actually vanilla, send me your datafile, here or in a pm, you're also welcome to message me on discord AnExiledDev#0001.
Honestly every major update was going to have a converter, it was in the plan for v3 and v4. But I went from one soul sucking job to another and never actually had time to build an internal or external conversion tool. I have a few days off so I'm going to try and build an external converter.
One day I want to setup some basic server hosting with custom control panels, not the cookie cutter bs panels everyone uses that only partially work, or has never heard of "user friendly".pookins
I have never used "the really nice editor" i always use the same system for large edits, I copy the config to a "new text file"
and edit it to what i want then validate it, then unload plugin (if its a data file) and copy/paste the new edit to replace the old one, my server host has a page time limit which does not give enough time to edit a large file so its easier that way, and it also gives me a copy of the config to re-edit if needed.
I only run 92 plugins but the bot plugin was replaced with a new version which had many issues with the FP chaos,
A follow up to my initial post in this thread:
Thank you very much AnExiledDev for sending me a converter. It worked perfectly and brought my old data file into a format I could just copy and paste into the new config file. Bravo sir!
Thanks! I'll release that converter soon. Wanted to tack on v2 to v4 first but work isn't going to let that happendeano79A follow up to my initial post in this thread:
Thank you very much AnExiledDev for sending me a converter. It worked perfectly and brought my old data file into a format I could just copy and paste into the new config file. Bravo sir!