When loading the plugin I am getting the followng in console:
(10:26:08) | Duplicate permission registered 'skinshop.admin' (by plugin 'Skin Shop')
(10:26:08) | Duplicate permission registered 'skinshop.use' (by plugin 'Skin Shop')Thais is caused by the plugin registering permissions manually and also registering them with the Permission attribute. Only one method should be used, not both.
If using the attribute, additional checks in the method are also unnecessary.
So just to be clear if I have this?
[Command("skinshop"), Permission(useSkinshopPermission)]permission.RegisterPermission(useSkinshopPermission, this);Yes, but you'd also want to remove any duplicate permission checks at the start of any commands as the attribute has a check of its own. I'd personally stick with the manual way though.Rustoholics
So just to be clear if I have this?
Then I can remove this?[Command("skinshop"), Permission(useSkinshopPermission)]permission.RegisterPermission(useSkinshopPermission, this);
Why? Attribute at the command seems simpler than registering manually and checking manually?Wulf
I'd personally stick with the manual way though.
In my cases, I offer customization of the commands and the messages, which you can't do with the attribute.Why? Attribute at the command seems simpler than registering manually and checking manually?
This has been resolved in version 0.5.0