1. Community
  2. Plugin Support
  3. Simple Kill Feed
Updated code 2.1.2
Plugin Page
Posted 3 years ago
#1

Hi might be a couple of un needed tests in 2.1.2

privatevoidOnEntityDeath(BaseAnimalNPCvictim, HitInfohitInfo)

privatevoidOnEntityDeath(SimpleSharkvictim, HitInfohitInfo)
 


These declarations are "overloaded" and so would filter out evertyhing else / but filter  "In" these types 
"BaseAnimalNPC","SimpleShark"

so I think   "victimisBasePlayer"  check in the "if" will not work, since teh passed types are relevent only to the two above.

it's an "or"  so it is non blocking... but mabe still un needed....

Posted 3 years ago
#2

god how i missed that..cheers

Posted 3 years ago
#3

you might have a floating return as well... anyway no need to do an update  until next time

OnPlayerDeath

if (!_config.EnableSuicides) return;
OnSuicide(victim); return;
return;
}

I think we can say its already returned... but you never know with FP code ;-
)
Posted 3 years ago
#4

i put them in their own hooks to avoid the global entity check

Posted 3 years ago
#5

It's fine.... it's your code....
it's not like it gonna over clock and make the computer burst into flames....