I use the SpawnMini plugin and it when players spawn in the minicopter now, the SAM Sites start shooting at them. Not all the time, just sometimes.
This doesn't happen on the older version of the plugin. It just happened since the plugin was updated.

The SAM sites don't shoot at minicopters that are bought from Bandit Camp, only the ones that players can spawn in.

To clarify the behavior you are seeing, it's shooting the minis while the player is flying them? And the player is authed on the tool cupboard of the Sam site?

When making the changes for the latest release, I was actually testing with Spawn Mini and did not have the issue you are describing.

The main thing that's different about the plugin now is that it will no longer do "vicinity" checks. I can only assume that those checks were being done because the developer didn't know how to efficiently check whether a player was on a hot air balloon or in the back of a scrap heli. If you are at the top of your base and spawn a minicopter, sam sites at the bottom of the base will shoot at it because the vicinity check is no longer happening. If this is the issue, we can probably introduce a check to see how recently the mini spawned, to prevent shooting it immediately after spawn and/or if not mounted.

Ok, looks like you are correct, I think a check will need to be introduced. 

There are two scenarios so far with the players authed on all TCs both times.

1. Player spawns in the minicopter and the SAMs start shooting.
2. Player lands in base, jumps off minicopter and the SAMs start shooting.

Here is an example of when a player is on their roof and spawns in a minicopter.  https://youtu.be/IF2ROEBpmzk

Thanks for sharing that video. That helps a lot.

I looked back at the previous code and saw something I didn't realize was happening before. Sam site targeting was also being prevented if the minicopter or scrap heli had no pilot. I suppose we could add that check back into the plugin, especially considering that it was an unintentional behavior change. I'll submit that change this weekend.

I've submitted a PR on GitHub to restore the functionality to make Sam Sites ignore emtpy vehicles. I now see that the documentation stated that was a feature (oops).

https://github.com/haggbart/rustplugin-samsiteauth/pull/2

WhiteThunder

Thanks for sharing that video. That helps a lot.

I looked back at the previous code and saw something I didn't realize was happening before. Sam site targeting was also being prevented if the minicopter or scrap heli had no pilot. I suppose we could add that check back into the plugin, especially considering that it was an unintentional behavior change. I'll submit that change this weekend.

Merged post

I've submitted a PR on GitHub to restore the functionality to make Sam Sites ignore emtpy vehicles. I now see that the documentation stated that was a feature (oops).

https://github.com/haggbart/rustplugin-samsiteauth/pull/2

Nice! Thank you very much!