I recently made a rust server following the one click guide of this video: https://youtu.be/DKDvr0ntjTg

The server works fine, i can join with localhost or my ipv4 address in the rust console, bit when i give the public IP to my friends they fail to connect.

I did the port foword both on the modem and the firewall, so i don't know what to do to make it work.

If you are able to connect locally then you definitely have an error with your port forwarding or firewall. Try switching your firewall off, and if that fixes it then you know it's a firewall config issue, otherwise it's your ports.

i tried disableing it and it worked, what do i need to do to port forward it?
it was forwarded in 28015, 28016 and 28083, both inbound and outbound in tcp and udp

If it worked when you disabled the firewall, then you need to make sure all your ports are configured in the firewall before you switch it back on again.

i rececked and i don't find the problem, both inbound and outbound rues for all the port i listed before in udp and tcp

Screenshot your portforward settings and firewall settings.

i couldn't upload the foto direclty, so i put them in drive: https://drive.google.com/drive/folders/1O23XrkqhnEpQlxrimNsUra6l4SSXCFga?usp=sharing

It looks OK, although you could remove some of those entries - 28015 is UDP, the others are TCP

Apart from that I'm out of ideas, sorry.

thanks, at least now i know where the issue is