Friends cant join my server

If the firewall is off and you are able to join locally but others are not able to from outside, then your port forwarding is not configured properly.

Show us your port forward settings.

use this tool to see if your ports are really open or you just think they are

I wouldn't trust that tool, it reports that my (working fine) ports are closed.