Hi,

just something i noticed with paratroopers

if you setup a kit

/kit add bob

this inserts an empty kit, if you do ot add anything to the kit whjen the API is called is passes null items......

How do you expect it to add a kit with items if you have not already added those items to the kit you created with the kits setup menu ? , just because you create a "kit name" does not mean you have created a kit with any function or contents,
In Botspawn you create a bot with a kit, but you have already created that kit with the kit plugin menu,

Thanks for you valuable input.
Maybe you should go read up on non-sequentiual processing...., thread safety & race conditions....

Failed to call hook 'GiveKit' on plugin 'Kits v3.2.95' (NullReferenceException: Object reference not set to an instance of an object)
  at Item.CanMoveTo (ItemContainer newcontainer, System.Int32 iTargetPos, System.Boolean allowStack) [0x0000b] in <3724ddbd3ebb41778fcd21f33b350975>:0 
  at Item.MoveToContainer (ItemContainer newcontainer, System.Int32 iTargetPos, System.Boolean allowStack) [0x00013] in <3724ddbd3ebb41778fcd21f33b350975>:0 
  at Oxide.Plugins.Kits.BuildWeapon (System.Int32 id, System.UInt64 skin, System.Collections.Generic.List`1[T] mods) [0x00071] in <14f56843de0b46c5a5ca6f4cbe20a0d2>:0 
  at Oxide.Plugins.Kits.GiveKit (BasePlayer player, System.String kitname) [0x00072] in <14f56843de0b46c5a5ca6f4cbe20a0d2>:0 
  at Oxide.Plugins.Kits.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00738] in <14f56843de0b46c5a5ca6f4cbe20a0d2>:0 
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <8a646463979e4a1d9c0e2f1298e9483f>:0 
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <1fe782f4b27a43ae85d29ebb2d56c007>:0 
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <1fe782f4b27a43ae85d29ebb2d56c007>:0 

No problem , you are the one with empty kits , have fun with it,
I am using 22 different kits without any hassles , Whether or no it has anything to do with sequential processing or any other crap you can throw in  :)

Perfectly acceptable work flow....
/kit remove bob
/kit add bob
(race condition for ANY plugin systems using bob)
/kit items hide true

It is better you say nothing about how "clever" you think you may be......

the input for /kit.. possibly needs to be correctly checked & sanatised.
it is possible for the the plugin to say it has corectly copied data when it has not & to throw a semi-silent "error"

/kits add soldier_05
/kit items cooldown false authlevel 2 hide true

will show that the kit is copied, shows no errors on client screen but throws:

Failed to call hook 'cmdChatKit' on plugin 'Kits v3.2.95' (FormatException: Input string was not in a correct format.)
  at System.Number.ParseDouble (System.String value, System.Globalization.NumberStyles options, System.Globalization.NumberFormatInfo numfmt) [0x0008f] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Double.Parse (System.String s, System.Globalization.NumberStyles style, System.Globalization.NumberFormatInfo info) [0x00000] in <437ba245d8404784b9fbab9b439ac908>:0
  at System.Double.Parse (System.String s) [0x0000b] in <437ba245d8404784b9fbab9b439ac908>:0
  at Oxide.Plugins.Kits.cmdChatKit (BasePlayer player, System.String command, System.String[] args) [0x00982] in <bb3c9f1de93d4d15bea2cf9c1e15de97>:0
  at Oxide.Plugins.Kits.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x0102a] in <bb3c9f1de93d4d15bea2cf9c1e15de97>:0
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <8a646463979e4a1d9c0e2f1298e9483f>:0
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <1fe782f4b27a43ae85d29ebb2d56c007>:0
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <1fe782f4b27a43ae85d29ebb2d56c007>:0

I didnt see any reference to /kit items ,  which would add the items in your inventory (the kit contents) to the kit, a confirmation message will appear attesting that the contents were added.
The kit plugin has been working quite well for the past 5 years i have been using it, The only problems occur when users dont read all the information and watch either or both of the instructional videos then blame the plugin for not working.

either way, it should be fixed ;p