1. Community
  2. Plugin Support
  3. Remover Tool
Players can be "removed" in admin mode, leads to client crashSolved
Plugin Page
Posted 4 years ago
Last updated 4 years ago
#1
As the title states, in admin mode you are able to delete players. I don't believe this is intended as it crashes the "victims" client with a NullReferenceException.

Thanks in advance and keep up the great work!

Regards,
Higgins
Posted 4 years ago
Last updated 4 years ago
#2
Do not abuse the admin mode.
The admin mode is the same as "ent kill"

Merged post

Need to change the way it works?
Posted 4 years ago
#3
lol? We are not abusing admin mode but one of our admins just found out that this is possible. I would say it has to be changed because a client crash should be unacceptable.
Posted 4 years ago
#4
In admin mode, any entity can be removed..
Posted 4 years ago
#5

Regardless if it leads to client crashes? That's an interesting approach. What happens to hooks in plugins using that Baseplayer object? What happens to hooks which should run due to the client disconnecting but its object being null? If its a sleeping player, will the server properly remove him from BasePlayer._sleepingPlayers? To me this approach creates too many unexpectable situations as it is an unclean way of disconnecting the user.

Posted 4 years ago
#6
Must be something server specfic......
removed tens of players over the last few days and no server crash or even error.

BUT........ they were sleeping...
Posted 4 years ago
Last updated 4 years ago
#7
It's not server specific. Of course nothing happens to sleeping players who are not connected. We are talking about active players that get disconnected in a way that no OnPlayerDisconnected hook can handle because the player object is null. Also, nobody is saying the server crashes or shows an error, I suggest you read the thread before commenting again.

Merged post

Almost 4 days later and no answer to any of my valid questions regarding the inpact of other plugins.
I'm not going to get into a discussion about your responsibility as a plugin maintainer to make sure its safe for both server and client because obviously you do not care.
Instead I will go ahead patch it for our server myself and start maintaining it so we do not rely on you anymore.
I just hope that you're not actively developing C# applications for a company with this attitude.

For educational reasons though, I will tell you how a professional developer could have handled this:

1. Acknoledge the problem instead of playing it down or even accusing the OP of abuse.
2. Ask the OP if he can provide a screenshot/video of the issue for you to verify
3. If confirmed, fix your bug (2 lines of code in this case!):
if (player.IsConnected)
    player.Kick(nameof(RemoverTool));
//ent kill​ code
4. Verify yourself or ask OP to verify using a test build.
5. Once verified, release update to public.

HTH, Higgins
Locked automatically