With cooperation with KHAN we noticed that something in your plugin is causing or atleast calling for oxide duplicated permissions, first i report this issue to GUIShop but he was only pasting message and nothing to do with his plugin. Plugin is constantly granting out the same permission over and over to players who already have it (assigned from Group, i never use direct assign except this plugin)

Then its looks like:

(21:28:16) | [GUIShop] This user 76561############ is already in a group that has raidprotection.ui please remove duplication

And thats pretty spammy

When i check this permission it shows:

(20:43:46) | Permission 'raidprotection.ui' Players:

No players with this permission

Permission 'raidprotection.ui' Groups:

default

When i unload raidprotection plugin, this spamming stop and also my CPU on server is getting better performance :) 

The message is coming from GUI Shop; other plugins aren't going to fix the spam from it. Having a permission granted already isn't something for a plugin such as this to fix either, since most permissions are granted by you or other plugins, such as GUI Shop.

If you want the message spam to stop, GUI Shop needs to stop spamming messages about players already having a permission.

So you are saying a plugin can do this in their code and it would pass umod standards? 

No, I see what the issue is now, the plugin is granting a permission and revoking it each time it opens and closes the UI; which is odd and shouldn't be using permissions that way. The permission not being documented also needs to be fixed, even if only used internally.

Reciews aren't currently handled for plugin updates either.

Wulf

The message is coming from GUI Shop; other plugins aren't going to fix the spam from it. Having a permission granted already isn't something for a plugin such as this to fix either, since most permissions are granted by you or other plugins, such as GUI Shop.

If you want the spam to stop, GUI Shop needs to stop spamming messages about players already having a permission.

Yes message is comming from GUIShop because i was asking KHAN to help me catch this error, its causing CPU performance drops because of RaidProtection, rather than spam i would fix the cpu drops :) and its caused by wrong code on line: 1529 & line: 1812

Would be possible to review it please ? 

I have my error response in the guishop for my own reasons to prevent miss proper shop setups, etc.
I can't control if other plugins fail to use permissions accordingly thus causing console spam.
If users want console spam to stop this plugin should be updated to address the improper use of permissions.

khan

I have my error response in the guishop for my own reasons to prevent miss proper shop setups, etc.
I can't control if other plugins fail to use permissions accordingly thus causing console spam.
If users want console spam to stop this plugin should be updated to address the improper use of permissions.

The hook I use in guishop is almost never spammed or even outputted into the console. Unless a user ( staff/owner of server ) is setting up their shops incorrectly I have to do this to alert them.

This is the only plugin on all of umod that has been found so far to cause console spam from my coding checks.
So I do already reduce it as much as humanly possible given the provided oxide hooks.

I can look into resolving this issue with my plugin. For the sake of learning, how should I go about restricting players from using commands that the CUI uses when they are not using that control?

If permissions are not the right solution, I'd be more than happy t incorporate the correct method.

mr01sam

I can look into resolving this issue with my plugin. For the sake of learning, how should I go about restricting players from using commands that the CUI uses when they are not using that control?

If permissions are not the right solution, I'd be more than happy t incorporate the correct method.

I ended up removing this permission, so the spam should no longer happen in v2.1.7.