uMod - NullReferenceException at OnEntityDeath - Raid Alarm

Posted 4 years ago

Last updated 4 years ago

Not seen this one before spammed into console this morning.

[Error] Failed to call hook 'OnEntityDeath' on plugin 'RaidAlarm v0.2.0' (NullReferenceException: Object reference not set to an instance of an object)
  at Oxide.Plugins.RaidAlarm.OnEntityDeath (BaseCombatEntity entity, HitInfo info) [0x000c9] in <bf8640b5208c482dbc4c97b9cc61db64>:0
  at Oxide.Plugins.RaidAlarm.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00183] in <bf8640b5208c482dbc4c97b9cc61db64>:0
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <d09a1f46ca2f4432811bcfe45ad13c7b>:0
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <cf88a28c7fb44d36890d85a78331cc9d>:0
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <cf88a28c7fb44d36890d85a78331cc9d>:0

Posted 4 years ago

Last updated 4 years ago

Are you running any plugins that affect cupboard authorization? For example, a plugin that automatically authorizes a player on the cupboard?

Based on the code, this looks to be the same issue the Auto Turret Authorization by the same author plugin also experienced, which is that sometimes there is a null entry in the authorized player list which the plugin doesn't account for. Not sure as to which plugin is adding those but it probably doesn't hurt to have plugins be resilient to that so I've submitted a patch for the author to review and merge when they have time.

Posted 4 years ago

Yes the only 2 are

AutomaticAuthorization

SAMSiteAuth

Posted 4 years ago

AutomaticAuthorization never adds null entries to the cupboard authorized players list, so it cannot be the cause.

SAMSiteAuth only reads from the cupboard authorized players list, it doesn't update it, so that cannot be the cause either.

I also couldn't find anything in the game code that is adding null entries.

If you search the code of your plugin directory for authorizedPlayers, you may be able to find other plugins that may be doing it, but a code search won't match obfuscated plugins if you have any of those.

Posted 4 years ago

I found 2 others using the code you supplied

MiniCopterOptions &

EntityOwner

Posted 4 years ago

MiniCopter options just authorizes turrets, and also doesn't null entries, so it cannot be the cause.

EntityOwner does touch authorized player lists in several places in the code, but it doesn't seem to add null entries anywhere either.

At this point, we're probably not going to find the root cause unless somebody else is having a similar issue and can provide more info. Seems it's been happening to folks as early as 4 months ago based on when it was reported in another plugin (https://umod.org/community/auto-turret-authorization/22130-nullreferenceexception-at-isauthed). Some other plugins such as sam site auth may end up with the same error at some point (when a particular cupboard has a null entry and there's a sam site at that base).

Posted 4 years ago

I've only seen the error once .. ill monitor and see if it pops again .. But Many thanks for the time and effort in responding white thunder im running 4 servers with similar mods..

2 years after

Posted 2 years ago

Getting this same error. I am using Dynamic Cup Share, could this be the issue?

NullReferenceException at OnEntityDeathError