Hey, this is going to sound really weird but I had your plugin running and supply signals stopped working. You could throw them, but no plane would ever arrive. Uninstalled your plugin, everything went back to normal.
Prior to that I'd tried setting it to multiple trails. Not sure if that contributed.
Stops Air Drops?Fixed
This might be caused by the following code in the plugin.
private void OnEntitySpawned(SupplySignal supplySignal)
{
if (supplySignal == null)
return;
supplySignal.CancelInvoke(supplySignal.Explode);
supplySignal.Invoke(() => {
supplySignal.SetFlag(BaseEntity.Flags.On, true);
supplySignal.SendNetworkUpdateImmediate();
}, 0);
}This code is obviously "bad" because it doesn't take into account whether the supply signal was spawned by this plugin. My suggestion for the plugin maintainer would be to not use this hook at all. Instead, whenever explicitly spawning a supply signal, perform this logic at that time for that specific supply signal.
Yep thats an oversite by me! I'll fix this as soon as possible.
Nice, thanks for looking into it.
Is this fixed in 2.1.1?
AbundantMuscle
Is this fixed in 2.1.1?
Yes this is fixed.
Salsa
Yes this is fixed.
I just tested it and when the plugin is enabled and I throw an supply drop, the pink smoke just stays on the ground and no supply drop occurs.
AbundantMuscle
I just tested it and when the plugin is enabled and I throw an supply drop, the pink smoke just stays on the ground and no supply drop occurs.
This was an error on my part. Sorry for the confusion. This is fully fixed in 2.1.2.
Excellent I'll load it up at lunch time and give it a quick test, amazing plugin by the way, can't believe no one thought of it until now.Salsa
This was an error on my part. Sorry for the confusion. This is fully fixed in 2.1.2.
AbundantMuscle
Excellent I'll load it up at lunch time and give it a quick test, amazing plugin by the way, can't believe no one thought of it until now.
should check our server out, Salsa is our Lead dev for most of our work that's not paid or already on umod, our discord is possibly the quickest way to reach us to sort a problem as we are very active on there