Yeah bump on this!

could you add tunnel dweller. thanks

I was also keen for this... have modified the code on my server and have it working nicely - @LaserHydra I've opened a Pull Request on GitHub ;)

darkaz

I was also keen for this... have modified the code on my server and have it working nicely - @LaserHydra I've opened a Pull Request on GitHub ;)

I know my way around a json/cs file enough to be able to edit things using Atom. Care to share the changes so I can get it working on my server, please? 

Philoludos

I know my way around a json/cs file enough to be able to edit things using Atom. Care to share the changes so I can get it working on my server, please? 

darkaz

I was also keen for this... have modified the code on my server and have it working nicely - @LaserHydra I've opened a Pull Request on GitHub ;)

I've tried your new version 6.3.6 but I can't seem to get it to work. I added "tunneldweller": 17 (also tried "TunnelDweller": 17) to the data file but there is still no death announcement for them, and when the plugin reloads it removes the TunnelDweller entry from the data file. I tried removing my existing config file and let it create a new one but still no joy. I may be doing something wrong...

@JimDeadlock You'll need to modify the code to prevent it from downloading (and overriding) the config file each time for tunnel dwellers to work. I'm hoping things get merged in and the updated config released soon, otherwise I can provide you with details on how to do this

Merged post

Heavy Scientists added to the PR also - see: https://github.com/LaserHydra/DeathNotes/pull/11

darkaz

@JimDeadlock You'll need to modify the code to prevent it from downloading (and overriding) the config file each time for tunnel dwellers to work. I'm hoping things get merged in and the updated config released soon, otherwise I can provide you with details on how to do this

Merged post

Heavy Scientists added to the PR also - see: https://github.com/LaserHydra/DeathNotes/pull/11

I'd love to know how to modify the code to prevent it from being overwritten. As everytime I add the tunnel dwellers into the data file it just gets removed upon reload.

RocketManKianYT

I'd love to know how to modify the code to prevent it from being overwritten. As everytime I add the tunnel dwellers into the data file it just gets removed upon reload.

Wulf

Unload the plugin first.

Just tried that. Unloaded, edited the CombatEntityTypes file, reloaded the plugin and then it overwrit the file and removed it.

When reloading the plugin, it re-dowloads the definitions from a remote source... you'll need to modify the Load method to prevent this.

I'm not adding this to the PR as it would modify existing functionality, but if you want to utilise things in the meantime a change to add this can be found on a separate branch here: https://github.com/johnmcclumpha/DeathNotes/blob/temp/prevents-remote-loading/DeathNotes.cs

They dont show up for me either. Do I have to do anything or this plugin needs update?

I already tried reloading and all that and added the stuff to the config

​

      {
        "KillerType": "TunnelDweller",
        "VictimType": "Player",
        "DamageType": "*",
        "Messages": [
          "{victim} was taken out by a {killer}."
        ]
      },
      {
        "KillerType": "Player",
        "VictimType": "TunnelDweller",
        "DamageType": "*",
        "Messages": [
          "{killer} took out a {victim} with their {weapon}."
        ]
      },
      {
        "KillerType": "Player",
        "VictimType": "Animal",
        "DamageType": "Collision",
        "Messages": [
          "{killer} ran over a {victim}."
        ]
      },
      {
        "KillerType": "Player",
        "VictimType": "Player",
        "DamageType": "Collision",
        "Messages": [
          "{killer} ran over {victim}."
        ]
      },​

Step 2 add this in oxide/data/DeathNotes/CombatEntityyTypes.json

{
  "GunTrap": 6,
  "FlameTurret": 7,
  "AutoTurret": 7,
  "BaseHelicopter": 0,
  "BradleyAPC": 1,
  "BasePlayer": 5,
  "NPCMurderer": 3,
  "CodeLock": 12,
  "Scientist": 4,
  "ScientistNPC": 4,
  "HTNPlayer": 4,
  "NPCAutoTurret": 13,
  "FireBall": 11,
  "scarecrow": 16,
  "tunneldweller": 17
}

Step 3 replace oxide/plugins/DeathNotes.cs with this: https://github.com/johnmcclumpha/DeathNotes/blob/temp/prevents-remote-loading/DeathNotes.cs

Thanks, Goldie! That worked!

Philoludos

Thanks, Goldie! That worked!

Thanks Goldie

Is it possoble to just Update the Plugin? I feel i'm going to make a mess trying to edit all these lines, but thanks anyway for the work you guys did!