When a toolcupboard is destroyed using explosives (timed explosive charges, rockets, etc.) or the foundation below the TC is removed with the remover tool, then the map markers do not always update to delete the marker from the map. Running the command /tcmap update seems to only add markers for existing TCs, and does not remove the ones that have been destroyed in this way. Players sometimes get confused because they can see markers for toolcupboards that are no longer there. Please provide a patch to fix these issues. Thank you.
TC markers not updating correctly
Do you use the latest version?
No I downloaded the version from 3 months ago, what do you think lol. Of course I used the latest version (v1.1.1).
Merged post
As an interim solution I have added some custom code to my own version of the plugin that adds a timer value to the configuration file (configData.UpdateInterval). I then created a custom timer code block. The timer function runs your function RemoveMapMarkers(), followed by the LoadMapMarkers() function every x seconds, depending on the configuration settings provided. This effectively updates all the map markers correctly by refreshing them every set interval. This method is working for me until something more official is provided here. Perhaps something along these lines would help others as well. Bless. <3
Merged post
As an interim solution I have added some custom code to my own version of the plugin that adds a timer value to the configuration file (configData.UpdateInterval). I then created a custom timer code block. The timer function runs your function RemoveMapMarkers(), followed by the LoadMapMarkers() function every x seconds, depending on the configuration settings provided. This effectively updates all the map markers correctly by refreshing them every set interval. This method is working for me until something more official is provided here. Perhaps something along these lines would help others as well. Bless. <3
I have checked the code, and you are right, there was an issue with the update command.
As for markers not being removed, that is weird, as in the code it should remove the marker when an entity (cupboard) is killed.
Did you unload plugin or something? Also, reloading the plugin will also help removing any markers.
I did not go with the update every x sec method, as I think this method is more performance friendly.
If you still have issues after the coming update, please let me know.
As for markers not being removed, that is weird, as in the code it should remove the marker when an entity (cupboard) is killed.
Did you unload plugin or something? Also, reloading the plugin will also help removing any markers.
I did not go with the update every x sec method, as I think this method is more performance friendly.
If you still have issues after the coming update, please let me know.
"Did you unload plugin or something?" No. I did not. I am quite certain that it is not a problem related to user error. But fair enough. I think I'll stick with my personal version for now as the outcome is predictable (the results will be the same aside from the new functions of the /tcmap update command). For my purposes it is imparitive that the map marker updates take place automatically at all times. I have a sneaking suspicion that the reason the TC map markers are not always updated correctly on the map as they are removed (or destroyed) is because the game does not always recognise the position of the toolcupboards exactly, thus failing to run the OnEntityKill function on them completely. There is an if statement included in the function that may cause this scenario to occur.
if (marker.transform.position == cupboard.transform.position)
{
marker.Kill();
marker.SendUpdate();
}This is of course just a suspicion and I have not tested it yet - I stopped playing with the code after I got it working with my custom version. The timer can be easily tied to a configuration variable as well, so users would not run the timer update functionality if it is set to false - allowing the user to pick the default operation for themselves. I have not noticed any performance issues using the customizable timer functions I created, granted my server hardware is top of the line and so it can more than adequately handle the extra processing required. At any rate, thank you for the update to the commands. Any progress is much obliged, and I thank you for your excellent work. Bless. <3
Thanks for the suggestion. You may be on the right track here, but the position of the placed tc is saved as the markers position.
Ofc, if the position on place tc somehow changes on OnEntityKill hook, that would be a problem.
But I have not noticed any problem running this on our Creative server.
Ofc, if the position on place tc somehow changes on OnEntityKill hook, that would be a problem.
But I have not noticed any problem running this on our Creative server.
Psyche
No I downloaded the version from 3 months ago, what do you think lol. Of course I used the latest version (v1.1.1).
Merged post
As an interim solution I have added some custom code to my own version of the plugin that adds a timer value to the configuration file (configData.UpdateInterval). I then created a custom timer code block. The timer function runs your function RemoveMapMarkers(), followed by the LoadMapMarkers() function every x seconds, depending on the configuration settings provided. This effectively updates all the map markers correctly by refreshing them every set interval. This method is working for me until something more official is provided here. Perhaps something along these lines would help others as well. Bless. <3
Could you please provide the code for the function you added?
AND/OR can we get this added to the default plugin as a configurable option so that persons who wish to use a timed feature may choose to do so. @1AK1