(18:31:19) | Calling hook OnItemSplit resulted in a conflict between the following plugins: CustomSkinsStacksFix - Item.explosive.satchelx10.5637243 (Item), StackSizeController (Item.explosive.satchelx10.5637245 (Item))
(18:31:22) | Calling hook OnItemSplit resulted in a conflict between the following plugins: CustomSkinsStacksFix - Item.explosive.satchelx1.5637588 (Item), StackSizeController (Item.explosive.satchelx1.5637590 (Item))
Remove CustomSkinsStacksFix. Skins should be maintained just fine for this plugin. I don't believe this is an issue that should be resolved within StackSizeController, unless someone is able to demonstrate why and how I can resolve the issue from my side I'm not going to debug as I think if anything it's an issue with the other plugin, can't say for sure though. Not really sure why a plugin like that exists, I think that should be handled by the individual plugins themselves to implement that hook correctly.
AnExiledDev
Remove CustomSkinsStacksFix. Skins should be maintained just fine for this plugin. I don't believe this is an issue that should be resolved within StackSizeController, unless someone is able to demonstrate why and how I can resolve the issue from my side I'm not going to debug as I think if anything it's an issue with the other plugin, can't say for sure though. Not really sure why a plugin like that exists, I think that should be handled by the individual plugins themselves to implement that hook correctly.
You should only return a new value if necessary, not in all cases.
You are correct, it should be handled by individual plugins. But there are many, well known and used plugins, free & paid for that do not. That plugin exists to rectify that. For example I used to use it as it handles stacked skinned items with custom names correctly, maintaining their custom name, skin etc when stacks were split until I made adjustments to the individual plugins which were not handling that hook correctly since the authors ddin't seem to.AnExiledDev
Remove CustomSkinsStacksFix. Skins should be maintained just fine for this plugin. I don't believe this is an issue that should be resolved within StackSizeController, unless someone is able to demonstrate why and how I can resolve the issue from my side I'm not going to debug as I think if anything it's an issue with the other plugin, can't say for sure though. Not really sure why a plugin like that exists, I think that should be handled by the individual plugins themselves to implement that hook correctly.
same here. I removed CustomSkinsStacksFix.
Calling hook OnItemSplit resulted in a conflict between the following plugins: CustomSkinsStacksFix - Item.hammerx1.7122904 (Item), StackSizeController (Item.hammerx1.7122906 (Item))
VooDooYou should only return a new value if necessary, not in all cases.
Thanks for catching that. I believe it won't adversely affect functionality, just potentially spam console. I'll fix in next release.
I have unloaded the CustomSkinsStacksFix plugin. So far so good. There were no more conflicts. Thank!