I use google wifi so it looks just a little different. I've got two-port rules set up one with internal and external ports being 28015 UDP and another 28016 TCP. I've also gone in my windows firewall and opened 28015-28016 on both TCP and UDP. Still, for others, the server is not responding. I can obviously connect LAN-wise. I had a couple of questions, first, am I missing anything. Second, my public IP is different from my IPv4 which I can see in Network in Sharing center and in google wifi, the rule runs through my IPv4. Does it matter if so how do I run it through my public IP? Lastly, my router creates different IPs through DHCP does that matter? does it need to be a static IP?

Is your server running on a wifi connection? Weird. When you say IPv4 I'm assuming you mean your local IP. If your DHCP changes the local IP of your server then it will break the port forwarding, so yes it's better to set the local IP to static if you can.

Apart from that you seem to have done everything correctly. Perhaps you have a 2nd firewall that you haven't taken into account? Maybe a firewall on your router and also on the PC running the server?

There is a (very slim) chance that your ISP may be blocking the traffic, it's something to consider if all else fails.

Here is a useful tool - it doesn't test your port forwarding but it can tell you if your external setup is correct:

https://southnode.net/steamquery.php

If you post a screenshot of your portforward settings here and also your external IP:port we can try to connect ourselves in case your friends are doing something wrong when trying to connect. If the forum filters your IP try PMing me with it.