Hello,

my players found out that bases that used to use the online/offline protection, who no longer have stored the necessary amount of scrap, decay or nearly disappear. Thats pretty bad and im not sure how to fix that.

Bases disappear when they used protection. Bases that never stored scrap in their tc dont decay... any help?

Just to clear things up, you're not expecting the raid protecion to also protect from decay right? Because this plugin does not protect bases from decaying, if players don't put in the neccesary resources (wood, stones, ect..) their bases will still decay and eventually disappear, even if they have "Raid Protection". This plugin protects bases from raiding damage, not decay.

Does this help? Or am I misunderstanding the issue? Let me know!

Hi mate, yes, I am aware that the plugin doesnt stop decay. I didnt noticed any further bases that have been wiped out of nowhere. So maybe it was just a server side temporary bug.

Oh okay, just making sure, let me know if anything else seems off. The plugin shouldn't affect decay or disappearing bases, maybe their protection ran out and got raided?

I also have had two players report this exact same thing happening. Both had plenty of scrap and resources in their TC yet one base completely dissapered and the other vanished all but a few foundations and walls.

Its a pve server so it was not raided by any players. 

I'm not having a moan but I think you need to look into this. I have removed the plugin for now and all seems ok. Would be nice if you could replicate this matter and hopefully come up with some sort of resolution.

Merged post

Don't know if its related but this has also been an issue:

I did try the new verion the other day and have just installed it again and now this error is coming up in the console:

25/08 05:19:53 | Failed to run a 1.00 timer in 'RaidProtection v2.1.4' (NullReferenceException: Object reference not set to an instance of an object)
at Oxide.Plugins.RaidProtection+ProtectedCupboard.UpdateHighestProtectionLevel () [0x000c5] in <35391e99ccf2487a99ed138edd000d37>:0
at Oxide.Plugins.RaidProtection+ProtectedCupboard..ctor (BuildingPrivlidge priv) [0x000c4] in <35391e99ccf2487a99ed138edd000d37>:0
at Oxide.Plugins.RaidProtection+ProtectedCupboard.InitCupboard (BuildingPrivlidge priv) [0x00030] in <35391e99ccf2487a99ed138edd000d37>:0
at Oxide.Plugins.RaidProtection.<LoadAllTcs>m__0 () [0x0002b] in <35391e99ccf2487a99ed138edd000d37>:0
at Oxide.Core.Libraries.Timer+TimerInstance.FireCallback () [0x00018] in <0fbce81d88d64454b3e7abb24df7026b>:0

I think a cache for GetBuildingPrivilege() is the only real solution. perhaps some implementation of this would work:

using Oxide.Plugins.TCacheEx;
using System;
using System.Collections.Generic;
using System.Linq;

namespace Oxide.Plugins
{
    [Info("TCache", "nivex", "0.1.0")]
    [Description("Cache to efficiently find a tool cupboard for an entity.")]
    class TCache : RustPlugin
    {
        private Cache cache = new Cache();

        public class Cache
        {
            public List<BuildingPrivlidge> TCs { get; set; }

            private Dictionary<BaseCombatEntity, BuildingPrivlidge> cache { get; set; } = new Dictionary<BaseCombatEntity, BuildingPrivlidge>();

            public BuildingPrivlidge Find(DecayEntity decayEntity)
            {
                foreach (var tc in TCs)
                {
                    if (tc.buildingID == decayEntity.buildingID)
                    {
                        return tc;
                    }
                }

                return decayEntity.GetBuildingPrivilege();
            }

            public BuildingPrivlidge Find(BaseCombatEntity entity)
            {
                BuildingPrivlidge priv;
                if (cache.TryGetValue(entity, out priv) && priv.IsValid() && !priv.IsDestroyed)
                {
                    return priv;
                }

                priv = entity.GetBuildingPrivilege();

                if (priv == null)
                {
                    return null;
                }

                cache[entity] = priv;

                return priv;
            }

            public void Remove(BuildingPrivlidge priv)
            {
                cache.RemoveAll((e, tc) => e == null || e.IsDestroyed || priv == tc);
            }
        }

        private void Init()
        {
            Unsubscribe(nameof(OnEntitySpawned));
            Unsubscribe(nameof(OnEntityKill));
            Unsubscribe(nameof(OnEntityDeath));
        }

        private void OnServerInitialized(bool isStartup)
        {
            cache.TCs = BaseNetworkable.serverEntities.OfType<BuildingPrivlidge>().ToList();
            Subscribe(nameof(OnEntitySpawned));
            Subscribe(nameof(OnEntityKill));
            Subscribe(nameof(OnEntityDeath));
        }

        private void OnEntitySpawned(BuildingPrivlidge priv) => cache.TCs.Add(priv);

        private void OnEntityKill(BuildingPrivlidge priv) => cache.Remove(priv);

        private void OnEntityDeath(BuildingPrivlidge priv, HitInfo hitInfo) => cache.Remove(priv);
    }
}

namespace Oxide.Plugins.TCacheEx
{
    public static class TCacheEx
    {
        public static void RemoveAll<TKey, TValue>(this IDictionary<TKey, TValue> dict, Func<TKey, TValue, bool> predicate)
        {
            var keys = new List<TKey>();

            foreach (var x in dict)
            {
                if (predicate(x.Key, x.Value))
                {
                    keys.Add(x.Key);
                }
            }

            keys.ForEach(key => dict.Remove(key));
        }
    }
}​

The hook time on this plugin is quite long as well

https://ibb.co/Y0qzRsW

Structures are still dissapearing on my server which kind of sucks becasue this is a really good plugin and the idea is awesome. But I have now made the decision to remove it from the server unfortunately due to the instability and issues. I was hoping that with the new version it wouldn't happen anymore but since i instaled it, player and even myself have had items dissapearing. Since removing it 6 hours ago, everything is fine again and nothing has gone.

I really hope that you can get this plugin working without errors. I look forward to that day.

I'll look into this

Any more progress on this with the newer versions?