1. Community
  2. Plugin Support
  3. Player Rankings
Working With Player Ranks (the ranking UI from Codefling)
Plugin Page
Posted 2 years ago
#1

If you're working with Player Ranks and you want these not to conflict over the chat command "ranks", add the following line of code and "rankings" will be registered with Player Rankings.

Edit the PlayerRankings.cs file in Notepad or Notepad++

Add the bold text below to your PlayerRankings.cs file.

 
        void OnServerInitialized()
        {
            if (!BetterChat)
                PrintWarning("Better Chat required in order to grant group titles; http://umod.org/plugins/better-chat/");
 
            SaveConfig();
            cmd.AddChatCommand("rankings", this, "RanksCommand");
            foreach (BasePlayer player in BasePlayer.activePlayerList)
                UpdateGroups(player);
 
 

Now in chat, you can use the Player Rankings /say command of "ranks" or "rankings".  Unless Player Ranks overwrites the "ranks" command.
Posted 2 years ago
#2

Why are you encouraging people to play around with .cs files ? . if you want something added to a plugin you put a suggestion in to the dev , submitting code for a plugin that is working is usually frowned upon, and why would anyone want to "mix" two plugins that do the same job ? .

Posted 2 years ago
#3

You apparently don't know the two plugins as they don't do the same thing.  And if you're frowning upon it, go look elsewhere is the recommended action.

The above change provides an opportunity to resolve a conflict between two plugins.  The opportunity to implement it is available to the developer which would be fantastic if they implemented.  If the developer chooses not to, there's no reason why a freely distributed plugin cannot be edited by those who obtain it to resolve conflicts they may also have, having an answer here to make their lives easier and avoid having to spend excessive time trying to find alternative resolutions.  This provides greater compatability and thus greater adoption and usage potential.

Posted 2 years ago
#4
nMyfFlEnglczTD3.jpg pookins

Why are you encouraging people to play around with .cs files ? . if you want something added to a plugin you put a suggestion in to the dev , submitting code for a plugin that is working is usually frowned upon, and why would anyone want to "mix" two plugins that do the same job ? .

Why would it be frowned upon? I've never heard of a dev having a problem with someone improving on their code, almost everyone myself included appreciates it as it helps with the workload.
If you can code, you put it to use, haven't had any problems with it so far.

Also, read more into the two plugins, it's not 'mixing' them, it's fixing a conflict lol. Saved me a bit of time.

Posted 2 years ago
#5
DarkMark

Why would it be frowned upon? I've never heard of a dev having a problem with someone improving on their code, almost everyone myself included appreciates it as it helps with the workload.
If you can code, you put it to use, haven't had any problems with it so far.

Also, read more into the two plugins, it's not 'mixing' them, it's fixing a conflict lol. Saved me a bit of time.

What generally happens with "patches" or "improvements" for plugins on this site (when Wulf was still active) is that a request would be made to the dev asking for it to be added or a hook implemented so that it could work with other plugins (on this site) and if the dev was agreeable for THEIR work to be edited they would do it.
And you have been with this site for 7 months and i have been on it and Oximod.org for 7+ years so i have seen many requests made in that time, some changes have been declined by devs as they do not think that it is something they would implement , and some have been accepted, The policy used to be that "random scripts" were not allowed to be posted but that seems to be overlooked now,
The fact that anyone can anyone can change the performance or function of a(n active) plugin without regard to the dev is surprising to me. the fact that the other plugin is from another site (and no request made to that dev) is also something that was not usually done in the past,  I suppose its more of new management , new rules

Posted 2 years ago
#6

It's effectively the nature and reason for open source code which has been a thing for a while.  It also takes pressure off of devs and can keep a good code base alive well past its life.  

Posted 2 years ago
#7
DarkMark

Why would it be frowned upon? I've never heard of a dev having a problem with someone improving on their code, almost everyone myself included appreciates it as it helps with the workload.
If you can code, you put it to use, haven't had any problems with it so far.

Also, read more into the two plugins, it's not 'mixing' them, it's fixing a conflict lol. Saved me a bit of time.

Yeah it got me too!  Glad it was helpful!
Posted 1 year ago
#8

Instead of modifying the cs file for this plugin, why not use the functionality that Steenamaroo has in the PlayerRanks config file to change the command for launching the Player Ranks UI? It's under options as follows:

"chatCommandAliases": [
"rank"

It would be nice if Player Rankings also offered such a config option; in the absence of it, however, I recommend the above to use both of these together.