1. Community
  2. Plugin Support
  3. Human NPC
OnKillNPC hook call passing wrong 2nd argument
Plugin Page
Posted 6 years ago
Last updated 6 years ago
#1
You have a small error in the plugin, the hook does not work when killing NPCs
OnKillNPC(BasePlayer npc, BasePlayer player)

Interface.Oxide.CallHook("OnKillNPC", entity.GetComponent<BasePlayer>(), hitinfo);

Need to do like this:
Interface.Oxide.CallHook("OnKillNPC", entity.GetComponent<BasePlayer>(), player);
Posted 6 years ago
Last updated 6 years ago
#2
Why would you need to do that? You can get the BasePlayer from HitInfo; the purpose of passing HitInfo is to get more than just the player. It would make more sense to pass it, so I'm not sure why the docs show the BasePlayer instead.
Posted 6 years ago
Last updated 6 years ago
#3
5e13a8d5b2bc5.jpg Wulf
Why would you need to do that? You can get the BasePlayer from HitInfo; the purpose of passing HitInfo is to get more than just the player. It would make more sense to pass it, so I'm not sure why the docs show the BasePlayer instead.

Yes, you can. But in any case in the plugin description there is an error, namely in OnKillNPC (BasePlayer npc, BasePlayer player)

Please compare the code and descriptions and you will understand what I mean

Will you correct the descriptions?
Posted 6 years ago
Last updated 6 years ago
#4
That's up to the current maintainer.
Posted 6 years ago
Last updated 6 years ago
#5
Well, we'll wait Merged post I solved this problem like this

Posted 6 years ago
Last updated 6 years ago
#6
That change would cause an NRE in some cases. It should pass the HitInfo instead else call removed into the null check for player.
Posted 6 years ago
Last updated 6 years ago
#7
Thanks, I’ll take it into account and fix it