If my understanding is correct, when Player spawns, `SpawnNewPlayer` method is called from ClientReady
Problem is... if I use OnPlayerSpawn and return a non null value, then SpawnNewPlayer returns null to the caller (to ClientReady).
This will case an NPE because following this call, ClientReady tries to call `basePlayer.SendRespawnOptions();` and
`basePlayer.LoadClanInfo();` without null checks.
So if my hook returns non-null value, ServerMgr.OnNetworkMessage will catch this exception and report: "Invalid Packet: Client Ready"
Shouldn't this hook return BasePlayer as returned by the plugin using the hook instead?
Btw this definitely worked before (like 1 year ago) because I've been using this hook and returning "true" back then. I just tried bringing my plugin back to life and now it's a problem.
Any support would be appreciated!
OnPlayerSpawn Hook Bug NPE
Opened a PR to fix this issue here