Hi, thanks for a great plugin! I'm having an issue where a scheduled restart doesn't cancel via 'announce.cancelscheduledrestart', even though the plugin says it's been cancelled. Happening with both the chat and console commands, and the countdown banner also continues to display after issuing the command.

Any ideas?

Just having a quick read through the code. All my testing ages ago when I wrote it was working fine, though I can't remember if there was something specific about trying to cancel it during the countdown..

Merged post

Well that's really odd.
Looking at the code:
There is a timer called SixtySecondsTimer which counts down the minute then issues the restart command to the server.
Giving the command to cancel a manually scheduled restart destroys that timer, as a result the command to restart the server cannot be issued and any further announcements halted.
It also removes that manually scheduled restart from the list of restart times so that it doesn't get triggered again.

So I can't see any reason why the functionality of it would have changed from working to broken.

Can you post a copy of your config in a code block please?

Merged post

The SixtySecondsTimer also has this:

Puts("Restart countdown finished.");

And I don't see that message in your console screenshot there.

Thanks for the quick reply :)

That I did see printed in the server console - just not in the client console:

(22:42:13) | [GUIAnnouncements] Restart countdown finished.​

I also tried issuing the commands into the console with "Restart My Server" set to false: announce.schedulerestart "00:05:00" and then immediately accounce.cancelscheduledrestart. The countdown timer proceeded and confirmed it finished, but no restart happened (looks like Restart My Server set to false overrides manually scheduled restarts as well by design). After it expired, the script seemed to be confused about what state it was in, and no further restart could be scheduled.

With Restart My Server set to false:

> announce.schedulerestart "00:05:00"
(23:07:24) | [GUIAnnouncements] Restart scheduled in 00:05:00.
(23:07:24) | [GUIAnnouncements] Next restart is in 00:05:00 at 23:12:20
(23:07:25) | [GUIAnnouncements] The server is restarting in 5 minutes.
> announce.cancelscheduledrestart
(23:07:33) | [GUIAnnouncements] A manually scheduled restart for 23:12 has been cancelled.
(23:08:25) | [GUIAnnouncements] The server is restarting in 4 minutes.
(23:09:25) | [GUIAnnouncements] The server is restarting in 3 minutes.
(23:10:25) | [GUIAnnouncements] The server is restarting in 2 minutes.
(23:11:26) | [GUIAnnouncements] The server is restarting in 59 seconds
(23:12:25) | [GUIAnnouncements] Restart countdown finished.
> announce.cancelscheduledrestart
(23:12:55) | [GUIAnnouncements] A restart has not been scheduled for you to cancel.
> announce.schedulerestart "00:02:00"
(23:13:19) | [GUIAnnouncements] Your server is about to restart, there is no need to schedule a restart right now.​

Then, changed Restart My Server to true and did 'oxide.reload GUIAnnouncements':

> announce.schedulerestart "00:05:00"
(23:15:15) | [GUIAnnouncements] Restart scheduled in 00:05:00.
(23:15:15) | [GUIAnnouncements] Next restart is in 00:05:00 at 23:20:11
(23:15:16) | [GUIAnnouncements] The server is restarting in 4 minutes.
> announce.cancelscheduledrestart
(23:15:28) | [GUIAnnouncements] A manually scheduled restart for 23:20 has been cancelled.
(23:16:15) | [GUIAnnouncements] The server is restarting in 4 minutes.
(23:16:16) | [GUIAnnouncements] The server is restarting in 4 minutes.
(23:17:16) | [GUIAnnouncements] The server is restarting in 3 minutes.
> announce.cancelscheduledrestart
(23:17:24) | [GUIAnnouncements] A restart has not been scheduled for you to cancel.
(23:18:15) | [GUIAnnouncements] The server is restarting in 2 minutes.
(23:19:16) | [GUIAnnouncements] The server is restarting in 59 seconds.
(23:20:15) | [GUIAnnouncements] Restart countdown finished.​

(Server restarted by the script)

Tested this as happening after a restart while Restart My Server was set to true as well.

I did add additional Announce With Time Left entries to my config - maybe this is causing the issue. I also edited the /lang/en config to remove references to the non-working commands /announcecancelrestart and announce.cancelrestart to trim down the text when using /announcehelp. Was thinking about removing the references to cancel/suspend commands, too, if not using scheduled restarts in the config.

Here's my full config per your request:

{
"A List Of Available Colors To Use (DO NOT CHANGE)": {
"Banner Colors": "Grey, Red, Orange, Yellow, Green, Cyan, Blue, Purple",
"Text Colors": "White, Red, Orange, Yellow, Green, Cyan, Blue, Purple"
},
"General Settings": {
"Adjust Vertical Position": -0.15,
"Announcement Duration": 10.0,
"Fade In Time": 0.5,
"Fade Out Time": 0.5,
"Font Size": 18
},
"Private New Player Announcements": {
"Announcements List (Show On This Many Joins : List To Show)": {
"1": [
"1st Join {rank} {playername} New player announcement 1.",
"1st Join {rank} {playername} New player announcement 2.",
"1st Join {rank} {playername} New player announcement 3."
],
"2": [
"2nd Join {rank} {playername} New player announcement 1.",
"2nd Join {rank} {playername} New player announcement 2.",
"2nd Join {rank} {playername} New player announcement 3."
],
"3": [
"3rd Join {rank} {playername} New player announcement 1.",
"3rd Join {rank} {playername} New player announcement 2.",
"3rd Join {rank} {playername} New player announcement 3."
]
},
"Banner Color": "Grey",
"Enabled": false,
"Text Color": "White"
},
"Private Respawn Announcements": {
"Announcements List": [
"{playername} Respawn announcement 1.",
"{playername} Respawn announcement 2.",
"{playername} Respawn announcement 3."
],
"Banner Color": "Grey",
"Enabled": false,
"Text Color": "White"
},
"Private Test Announcement": {
"Adjust Vertical Position": 0.0,
"Banner Color": "Grey",
"Duration": 10.0,
"Fade In Time": 0.5,
"Fade Out Time": 0.5,
"Font Size": 18,
"Text Color": "White"
},
"Private Welcome Announcements": {
"Banner Color": "Grey",
"Duration": 12.0,
"Enabled": true,
"Show Welcome Back If Player Has Been Here Before": true,
"Text Color": "White",
"Welcome Back Text": "Welcome back {playername}! There are {playercount} player(s) online.",
"Welcome Text": "Welcome {playername}! Please take a moment to read our rules."
},
"Public Airdrop Announcements": {
"Banner Color": "Green",
"Enabled": false,
"Show Location": false,
"Text": "Airdrop en route!",
"Text Color": "Yellow",
"Text With Coords": "Airdrop en route to x{x}, z{z}"
},
"Public Automatic Game Time Announcements": {
"Announcement List (Show at this in game time : Announcements to show)": {
"18:15": [
"The in game time is 18:15 announcement 1.",
"The in game time is 18:15 announcement 2.",
"The in game time is 18:15 announcement 3."
],
"00:00": [
"The in game time is 00:00 announcement 1.",
"The in game time is 00:00 announcement 2.",
"The in game time is 00:00 announcement 3."
],
"12:00": [
"The in game time is 12:00 announcement 1.",
"The in game time is 12:00 announcement 2.",
"The in game time is 12:00 announcement 3."
]
},
"Banner Color": "Grey",
"Enabled": false,
"Text Color": "White"
},
"Public Automatic Timed Announcements": {
"Announcement List": [
[
"1st Automatic Timed Announcement 1",
"1st Automatic Timed Announcement 2"
],
[
"2nd Automatic Timed Announcement 1",
"2nd Automatic Timed Announcement 2"
],
[
"3rd Automatic Timed Announcement 1",
"3rd Automatic Timed Announcement 2"
]
],
"Banner Color": "Grey",
"Enabled": false,
"Show Every (HH:MM:SS)": "00:30:00",
"Text Color": "White"
},
"Public Christmas Stocking Refill Announcement": {
"Banner Color": "Green",
"Enabled": true,
"Text": "Santa has refilled your stockings! Check out what you got <|:)}",
"Text Color": "Red"
},
"Public Helicopter Announcements": {
"Despawn": false,
"Despawn Banner Color": "Red",
"Despawn Text": "The patrol helicopter has left.",
"Despawn Text Color": "White",
"Destroyed": false,
"Destroyed Banner Color": "Red",
"Destroyed Text": "The patrol helicopter has been taken down!",
"Destroyed Text Color": "White",
"Destroyed Text With Destroyer": "{playername} got the last shot on the helicopter taking it down!",
"Show Destroyer": true,
"Spawn": false,
"Spawn Banner Color": "Red",
"Spawn Text": "Patrol Helicopter Inbound!",
"Spawn Text Color": "Orange"
},
"Public Join/Leave Announcements": {
"Announce Only Players With Permission": true,
"Join Banner Color": "Grey",
"Join Enabled": false,
"Join Text": "{rank} {playername} has joined.",
"Join Text Color": "White",
"Leave Banner Color": "Grey",
"Leave Enabled": false,
"Leave Text": "{rank} {playername} has left.",
"Leave Text Color": "White"
},
"Public Player Banned Announcement": {
"Banner Color": "Grey",
"Enabled": false,
"Text": "{playername} has been banned. {reason}.",
"Text Color": "Red"
},
"Public Restart Announcements": {
"Announce With Time Left (HH:MM:SS)": [
"12:00:00",
"11:00:00",
"10:00:00",
"09:00:00",
"08:00:00",
"07:00:00",
"06:00:00",
"05:00:00",
"04:00:00",
"03:00:00",
"02:00:00",
"01:00:00",
"00:45:00",
"00:30:00",
"00:15:00",
"00:10:00",
"00:05:00",
"00:04:00",
"00:03:00",
"00:02:00",
],
"Banner Color": "Red",
"Cancelled Scheduled Restart Text": "The server restart in {time} has been cancelled.",
"Enabled": false,
"Restart Announcement Text": "The server is restarting in {time}",
"Restart At (HH:MM:SS)": [
],
"Restart My Server": true,
"Suspended Restart Text": "The server restart in {time} has been suspended.",
"Text Color": "White",
},
"Third Party Plugin Support": {
"Do Not Overlay LustyMap": false,
"LustyMap Position (Left/Right)": "Left"
}
}​

Looks like some of the indents were lost there, if it matters, but are intact in the config.
Thanks again! Please let me know if you need anything else.

Ok I'll have to get my private server running again to run the tests and see if I can spot where the code screws up.

Thank you :)

Hi, just pinging you about this. Did you have a chance to look into it?

undertow

Hi, just pinging you about this. Did you have a chance to look into it?

I've had a quick look and haven't found anything yet. I'll let you know of further progress!