I took a look at what both are doing and I had to add the ENUM numbers into RustCord for the new things to be captured. I'd like to suggest a collaboration on the two mods to make it more update friendly. I don't really know how to code but I think it the Death Notes hook needs to include one of the catgories that RustCord is splitting the notes into the RustCord permissions of plugin_deathnotes_pvp/animal/vehicle/npc. Then RustCord can use that to determine its logic instead of having to add all the ENUM numbers from the combatEntity Enum.
If anyone's interested, this is the change I made to RustCord to make it report the new Death Notes starting on line 4026:
if (_DeathNotes != null)
if ((victimType == 5 && (killerType == 26 || killerType == 5 || killerType == 6 || killerType == 7 || killerType == 8 || killerType == 9 || killerType == 10 || killerType == 11 || killerType == 12 || killerType == 14 || killerType == 15)))
{
for (int i = 0; i < _channelCount; i++)
{
if (_settings.Channels[i].perms.Contains("plugin_deathnotes_pvp"))
{
GetChannel(Client, _settings.Channels[i].Channelid, chan =>
{
chan.CreateMessage(Client, Translate("PLUGIN_DeathNotes_Death", dict));
});
}
}
}
// else if ((victimType == 2 && killerType == 5) || (victimType == 5 && killerType == 2))
else if (((victimType == 2 || victimType == 25 || victimType ==27) && killerType == 5) || (victimType == 5 && (killerType == 2 || killerType ==25 || killerType ==27)))
{
for (int i = 0; i < _channelCount; i++)
{
if (_settings.Channels[i].perms.Contains("plugin_deathnotes_animal"))
{
GetChannel(Client, _settings.Channels[i].Channelid, chan =>
{
chan.CreateMessage(Client, Translate("PLUGIN_DeathNotes_Death", dict));
});
}
}
}
// else if ((victimType == 5 && (killerType == 0 || killerType == 1)) || ((victimType == 0 || victimType == 1) && (killerType == 5)))
else if ((victimType == 5 && (killerType == 0 || killerType == 1 || killerType == 22 || killerType == 23 || killerType == 24 || killerType == 29)) || ((victimType == 22 || victimType == 23 || victimType == 24 || victimType == 29 || victimType == 0 || victimType == 1) && (killerType == 5)))
{
message = (string)_DeathNotes.Call("StripRichText", message);
for (int i = 0; i < _channelCount; i++)
{
if (_settings.Channels[i].perms.Contains("plugin_deathnotes_vehicle"))
{
GetChannel(Client, _settings.Channels[i].Channelid, chan =>
{
chan.CreateMessage(Client, Translate("PLUGIN_DeathNotes_Death", dict));
});
}
}
}
else if ((victimType == 5 && (killerType == 3 || killerType == 4 || killerType == 16 || killerType == 17 || killerType == 18)) || ((victimType == 3 || victimType == 4 || victimType == 16 || victimType == 17 || victimType == 18) && (killerType == 5)))
{
message = (string)_DeathNotes.Call("StripRichText", message);
for (int i = 0; i < _channelCount; i++)
{
if (_settings.Channels[i].perms.Contains("plugin_deathnotes_npc"))
{
GetChannel(Client, _settings.Channels[i].Channelid, chan =>
{
chan.CreateMessage(Client, Translate("PLUGIN_DeathNotes_Death", dict));
});
}
}
}
}