Slight problem with skinsFixed

When you skin it with MonumentAddons and/or CustomVendingSetup it screws with the new update, both plugins are fighting for dominance for skins on vending machinces.

MonumentAddons has to take care of skins or CustomVendingSetup has to or you have big problem.

I tested the interaction between the plugins before releasing the update and did not see any major issues, but I think I overlooked some cases. In particular, if you already had a vending machine which was customized and also skinned by MA, then CVS will make that use the default skin rather than the one previously saved in MA. I will take a look and see how I can improve the integration to make it seamless.

Merged post

I have pushed updates to both plugins on GitHub. Can you test them together and let me know if it's doing what you expect?

https://github.com/WheteThunger/MonumentAddons

https://github.com/WheteThunger/CustomVendingSetup

Previously, the MA profile data file would look something like this:

{
  "Name": "Default",
  "SchemaVersion": 2.0,
  "MonumentData": {
    "fishing_village_c": {
      "Entities": [
        {
          "Id": "...",
          "PrefabName": "...",
          "Position": {...},
          "RotationAngles": {...},
          "Skin": 1780228760,
          "VendingProfile": {
            "ShopName": "Output Outfitters",
            "SkinId": 2186443994,
            "Offers": [...]
...

Now, after re-saving the vending machine, you will see this:

{
  "Name": "Default",
  "SchemaVersion": 2.0,
  "MonumentData": {
    "fishing_village_c": {
      "Entities": [
        {
          "Id": "...",
          "PrefabName": "...",
          "Position": {...},
          "RotationAngles": {...},
          "Skin": 1780228760,
          "VendingProfile": {
            "ShopName": "Output Outfitters",
            "Offers": [...]
...

Specifically, the SkinId property of the VendingProfile will no longer be present.

If you are in a temporary state where "Skin" is absent but "VendingProfile.SkinId" is present, then the latter will be used.

If you are in a temporary state where both fields are present, "Skin" will be used.

NKXTQs24ExGTuL8.jpg WhiteThunder

I tested the interaction between the plugins before releasing the update and did not see any major issues, but I think I overlooked some cases. In particular, if you already had a vending machine which was customized and also skinned by MA, then CVS will make that use the default skin rather than the one previously saved in MA. I will take a look and see how I can improve the integration to make it seamless.

Merged post

I have pushed updates to both plugins on GitHub. Can you test them together and let me know if it's doing what you expect?

https://github.com/WheteThunger/MonumentAddons

https://github.com/WheteThunger/CustomVendingSetup

Previously, the MA profile data file would look something like this:

{
  "Name": "Default",
  "SchemaVersion": 2.0,
  "MonumentData": {
    "fishing_village_c": {
      "Entities": [
        {
          "Id": "...",
          "PrefabName": "...",
          "Position": {...},
          "RotationAngles": {...},
          "Skin": 1780228760,
          "VendingProfile": {
            "ShopName": "Output Outfitters",
            "SkinId": 2186443994,
            "Offers": [...]
...

Now, after re-saving the vending machine, you will see this:

{
  "Name": "Default",
  "SchemaVersion": 2.0,
  "MonumentData": {
    "fishing_village_c": {
      "Entities": [
        {
          "Id": "...",
          "PrefabName": "...",
          "Position": {...},
          "RotationAngles": {...},
          "Skin": 1780228760,
          "VendingProfile": {
            "ShopName": "Output Outfitters",
            "Offers": [...]
...

Specifically, the SkinId property of the VendingProfile will no longer be present.

If you are in a temporary state where "Skin" is absent but "VendingProfile.SkinId" is present, then the latter will be used.

If you are in a temporary state where both fields are present, "Skin" will be used.

I'll try it out right now!



Merged post

It looks like the vending machines, like magic, got fixed in in both reloads.

Your the master, keep up the good work!

Thanks for confirming! I've now released both updates on uMod.

Locked automatically