I am using this plugin to disable the selling of certain items at Bandit and Outpost. My players have been complaining of two issues since we started using it. 1) Some stack sizes are no longer large like they were and 2) the amount of time it takes for the vending machine to refill is longer than before.
Varies from vanilla?Bug
Stock behavior should be vanilla by default. That is, 1 purchase of each item gets restocked every 10 seconds, up to 10 total purchases. Please provide evidence if you are seeing something different in vanilla or with the plugin.
This plugin should not be affecting stack sizes. Which specific vendors/items are you seeing this issue with?
WhiteThunder
Stock behavior should be vanilla by default. That is, 1 purchase of each item gets restocked every 10 seconds, up to 10 total purchases. Please provide evidence if you are seeing something different in vanilla or with the plugin.
This plugin should not be affecting stack sizes. Which specific vendors/items are you seeing this issue with?
The wood/stone exchange and pickles. I guess stone or wood stacked at 10k out of the machine and pickles stacked at 60, but they are not doing this anymore. And they claim that the time it takes to exchange the wood/stone is noticably longer than last wipe.
I did not find any issues with Pickles (Food Exchange at Bandit Camp). When selling 6 pickles for 1 scrap, up to 60 pickles are stocked at a time. I observed this behavior in vanilla and when the vending machine was overriden by the plugin.
I did find some issues with stones and wood (Resource Exchange at Outpost). The initial stock amount for wood was approximately 15k in vanilla, but 10k when overriden by the plugin (without making any changes). That happens because the plugin uses predictable stocking logic, while vanilla uses logic that is harder to predict and results in inconsistent stock amounts (a more detailed explanation of that can be found in this post). This only happens for items where the vending machine is selling the same item for multiple stack amounts (e.g., 1000 stones for 20 scrap, and 150 stones for 500 wood).
An example of vanilla itself being inconsistent is that the Scrap Exchange will initially stock 1400 scrap, but after buying all of it, it will stock only 835 scrap. The plugin addresses this issue by initially stocking 835 scrap to be more consistent.
Another factor is that the restock speed can be affected by the amounts you are selling items for. For example, if the vending machine sells stones at 1000 and 150, you may get up to 1150 stones stocked per cycle. If you remove the 1000 sale offer, then you will get at most 150 stones stocked per cycle. This is how the vanilla logic behaves, which the plugin is accurately replicating.
For now, I will report the inconsistent stock behavior as a bug to FP, and I suggest that you simply alter the max stock amounts for the items you want.