do these inherit from the static quarries instead of the normal ones?  because the static quarries were updated to use diesel, and now the pump jacks require it as well.  The normal quarries still use LGF.

The PumpJacks from this plugin do not inherrit from the static ones. They only output crude but do run on diesel, as do Quarries now too. I have submitted a patch to the author for their consideration, to arefelct the changes since the update. Hopefully they have time to look at it.

ZEODE

The PumpJacks from this plugin do not inherrit from the static ones. They only output crude but do run on diesel, as do Quarries now too. I have submitted a patch to the author for their consideration, to arefelct the changes since the update. Hopefully they have time to look at it.

Can you provide a link to this, please?

Thanks @ZEODE
It should be fixed now.

Arainrr

Thanks @ZEODE
It should be fixed now.

This isn't fixed. It outputs both crude and lgf now, but the ratio is still completely wrong. I pasted the new config file that you put on the main page, made a new pump jack, put in one barrel of diesel, and I got 16 LGF and 6 Crude. Clearly this result is wrong. It should be noted that we're not using Gather Manager, or any other plugin that would affect this. I suspect that either the duration is wrong, the pM values are wrong, or a combination of both.

With the patch I submitted, the config values I set made the pumpjacks output the Rust default vanilla output for crude and LGF, (I set at 2.7pM for crude and 7.5 pM for LGF). In my testing with my patch on the previous version, this output the same as the static PumpJacks around the maps. I haven't looked at how the calculations are done in this release, but it's obviously changed as the defaults the author has set in a default config are nothing like I would expect if the calculations were the same as in the previous version. I tested with the new release with a new default config and it sems to output too much, Please can @Arainrr let us know what values to put to get vanilla rates back please?

Kobani

The pump only returns Crude.oil. I left the standard configuration as it is in the cs. Of course I deleted the old one.

Is this the case for new pumps or existing ones? The changes will only be apparent on newly placed quarries I believe.

ZEODE

With the patch I submitted, the config values I set made the pumpjacks output the Rust default vanilla output for crude and LGF, (I set at 2.7pM for crude and 7.5 pM for LGF). In my testing with my patch on the previous version, this output the same as the static PumpJacks around the maps. I haven't looked at how the calculations are done in this release, but it's obviously changed as the defaults the author has set in a default config are nothing like I would expect if the calculations were the same as in the previous version. I tested with the new release with a new default config and it sems to output too much, Please can @Arainrr let us know what values to put to get vanilla rates back please?

I found that the formula ExpectedResult/2.10 gets you pretty well in the ballpark. Minus 1 or two from the actual output of the pumpjack. So, as an example, if you were targeting 84 crude as the final yield from 1 barrel of diesel, you'd do "84/2.10=40pM". But actual needed value to achieve that target was "40.5".

🤨What is the pm of pumpjack of vanilla?

ZEODE

Is this the case for new pumps or existing ones? The changes will only be apparent on newly placed quarries I believe.

new pumps

🤡I tested and did not have any errors, vanilla pumpjack's pm was 28.8(crude.oil) and 81.6(lowgradefuel)

Arainrr

🤡I tested and did not have any errors, vanilla pumpjack's pm was 28.8(crude.oil) and 81.6(lowgradefuel)

I think the confusion has come from the fact that you seem to have changed the calculation within your plugin on how it works out the pM of each mineral?

Vanilla rates for static PumpJacks around the map can be tested at monuemnts and produces 60 crude and 170 LGF for 1 barrel of diesel.

In the assembly under "UpdateStaticDeposit" the values can be seen:

        this._linkedDeposit.Add(ItemManager.FindItemDefinition("crude.oil"), 1f, 1000, 16.666666f, ResourceDepositManager.ResourceDeposit.surveySpawnType.ITEM, true);
        this._linkedDeposit.Add(ItemManager.FindItemDefinition("lowgradefuel"), 1f, 1000, 5.882353f, ResourceDepositManager.ResourceDeposit.surveySpawnType.ITEM, true);

Math check means:

1000 / 16.666666 = 60 crude
1000 / 5.882353 = 170 LGF

In  your previous version of the plugin within "ModifyResourceDeposit" where you handled the amounts and work needed, you wrote:

                            int amount = UnityEngine.Random.Range(10000, 100000);
                            float workNeeded = 45f / UnityEngine.Random.Range(permissionS.pumpJackS.pMMin, permissionS.pumpJackS.pMMax);
                            var crudeItemDef = ItemManager.FindItemDefinition("crude.oil");
                            if (crudeItemDef != null)
                            {
                                deposit.Add(crudeItemDef, 1, amount, workNeeded, ResourceDepositManager.ResourceDeposit.surveySpawnType.ITEM, true);
                                List<QuarryData.MineralItemData> mineralItemDatas = new List<QuarryData.MineralItemData> { new QuarryData.MineralItemData { amount = amount, shortname = crudeItemDef.shortname, workNeeded = workNeeded } };
                                activeCraters.Add(new QuarryData { position = oilCrater.transform.position, isLiquid = true, mineralItems = mineralItemDatas });
                            }

So a quick math check means:

45 / 16.666666 = 2.7
45 / 5.882353 = 7.65

Using these figures in your previous version matched the vanilla output of pumpjacks.

Therefore with version 1.4.12, which I submited a patch for consideration and suggested the pM of 2.7 and 7.65 were based on how you calculated it then. But with your latest version of the plugin those values output much less than vanilla output, tiny in fact. So without looking into what's changed on the latest version, I am assuming you have changed the calculation somehow.

The default config you have on the plugin documentation page has my suggested values, which don't work with your latest version. But the values you have suggested as the default in your latest version are different. However, the output using your suggested values on your latest version give too much output.

This is where the confusion has come about. 

PM is the number of items produced per minute, static pumpjack produces 28 crude oil and 81 fuel per minute.

Arainrr

PM is the number of items produced per minute, static pumpjack produces 28 crude oil and 81 fuel per minute.

How many pM work on one barrel of diesel fuel? After the update, careers began to work very slowly! Compared with vanilla quarry. Vanilla is faster! Fix this or add a speed setting to the config.