pookins

My suggestion is always to read the previous posts !.  This has been a continuing problem for the last 2 months and there have been many posts on Two threads.

Could you link me to those 2 threads please.

AnExiledGod

Alright, some items aren't stacking, some items are stacking. What update did this start happening on, and can you give me a few examples of items that do work and items that don't work? I'll see what I can find out. Thanks!

As stated in a previous thread this started to happen after the "fix" for ammunition exploit in version "0.4" so went back to version "0.2" and it all stacked ok, then when game updated previous to last update items stopped stacking again,
The anomoly is that i can loot and stack some items into my inventory and backpack but then then wont add to stacks in "storage" chests , once they are put into chests they wont "restack" in inventory, so i have stacks of weapons of 20+ in chests/inventory and single items that wont stack with them, I have turrets that wont stack but if i recycle them and then recraft them back to turrets they will stack (?) , i can stack test generators with no problem but then you get some that wont stack, the same with other items such as composters, simple lights, search lights, the list goes on, I am using version "0.2" as weapons dont stack at all in version "0.4" . Most resources stack with no problems at all, same with ammunition, tools, clothing.
As you can see i have grenade launchers that will stack but 3 that wont. same with jackhammers but rocket launchers wont stack at all.
https://i.imgur.com/poX5HRV.png

pookins

As stated in a previous thread this started to happen after the "fix" for ammunition exploit in version "0.4" so went back to version "0.2" and it all stacked ok

sorry this is NOT correct, it does not "all stack ok" and it never did.
It is severly broken, as regards "stacking in chests"  and stacking in general.

stacking in chests it is NOT the plugin it is rust. and how rust iterates over chests when slots are full /empty, there is alos a multitude of test that it is NOT doing before it returns "true/false/null"

You cannot just use a hook...... then completly discount the code that is executed  in the pre & post hook routine....
pretending it's not there..... UNLESS that is ..... you SPECIFICALLY don't want it to execute.

But in many cases for this plugin that is NOT the case.....
it's like the age old addage "if a tree falls in the forest and no one is there does it make a noise?"..

This particular tree is making allsorts of noises , killing squirres , crushing flowers & butterflies, but you aint in the forest....

razorfishsl

sorry this is NOT correct, it does not "all stack ok" and it never did.
It is severly broken, as regards "stacking in chests"  and stacking in general.

stacking in chests it is NOT the plugin it is rust. and how rust iterates over chests when slots are full /empty, there is alos a multitude of test that it is NOT doing before it returns "true/false/null"

You cannot just use a hook...... then completly discount the code that is executed  in the pre & post hook routine....
pretending it's not there..... UNLESS that is ..... you SPECIFICALLY don't want it to execute.

But in many cases for this plugin that is NOT the case.....
it's like the age old addage "if a tree falls in the forest and no one is there does it make a noise?"..

This particular tree is making allsorts of noises , killing squirres , crushing flowers & butterflies, but you aint in the forest....

To say "it has never did" is wholly inaccurate, I have been using it since CanopySheep released it in 2017 and although it had many teething problems i have had many years of reliability, This plugin cannot control restrictions that FP  introduced in the past on stacking "durable" items or weapons and "new" items.
Until the wipe 2 months ago i had no problems stacking anything. If FP have changed the way we stack yet again we will have to put up with it until a workaround can be implemented. You will also have to consider this might also be a leadup to when the threatened weight restrictions are introduced into the game and it will be impossible to carry 600k wood/stone/metal, or even an inventory full of weapons and ammo. I for one am not looking forward to that.

razorfishsl

You lack the insight to correctly analise the situation....

tell you what... go find my name on "ba***tmet*.com", go find my test server  (the one i play/test on.)
then go in and see how a REAL stacking plugin works...
see if you can break it.... (there are a couple of bugs.. that i will get round to)
see WHAT it does  and then come back compare the two , and dare say this one "it was not broken" before.

There are subtleties in rust effected by this plugin that you have not even thought about.......

IF your plugin is as good as you say it is where is it ?  and why then are you using and complaining about this one, its like some saying "my other car never breaks down and is more reliable than this one"  so why the hell use it ?.
And to say i dont have the insight to justify my opinion , who the F*** are you to judge that, and the word is
Analyse.

and as for insight, i have two steam accounts , one with nearly 24k and the other with nearly 8k on this game. i play on average a minimum 6 hours a day and have done since i bought the game 6 months after it came out, i dont need a "test" server i use a real one. And there is no way i am going to try waste time guessing what letters the ***** replace,

AnExiledGod

I can say definitively it's worked fine before because when I released it originally (I believe back in 2014 on Oxide) it was working fine excluding 1 issue I remember and that was due to a Rust limitation.

I'm sure a lot has changed, the original plugin was very simple, only 160 lines, now CanopySheep's is 570 lines, so I'm sure the complexity is higher now.

I'll be busy at least the next week, but once things have calmed down I'll run the plugin through a full test to get a full list of issues and see if I can get it into a near fully functional state. I'll want to give it a full face lift and bring it up to the latest best practices but that takes a while so want to see if I can get some patches out first. If anyone has suggestions on the recode please create a new topic to let me know.

Thank you for your hard work , I have been using it since its release (June 2015) and had some interesting arguments regarding stacking , I can remember being very annoying to Canopysheep when I (wrongly) blamed him for reducing the  stacking certain items when it was actually a "hard wired" change by FP, I do find now that some weapons will stack (M249, AK, L96) but Rocket launchers will not. I would say its 85% working and can put up with any problems till its fixed,

razorfishsl

Time tripping back into the past 6 years, is fine  for any servers running 6 year old code.
and yes you handed it off to someone else to manage.

But the discussion is that it was working "fine with no problems" 2 versions ago...
To which I called bullshit, by person or persons who clearly did not do a code analysis..
Why is this important?
Becasue it gives the false impression that it is easily fixable.

Like a user who logs into a web app & looks at the menu screen ,then later logs back in after an update, starts really using the app and declares "it was working fine the last time i logged in"

and pookins....
go find my test server on battlemetrics.com... , and stop trying to misdirect, you aint very good at it.
AS for judging ....it's like if i go to a guy that claims to be a mechanic..
and he says shit that is clearly not factual and can be disproved with the simplest of logical Analitical tests.
you know those pesky "test cases" they make you write for breaking software..

Even looking at the code you can CLEARLY see it will not stack correctly...

So when a statment is made that can be disproved with the absolute simplest of tests, then we can say that is bullshit.
I will say again that you appear to lack the insight to celarly analise what is going on or if the code is functioning correctly, or maybe you are some super genius that operates on a level beyound the relms of physics & logic?

as regrds my code...  Why should I put it into a community where some members rip off  & do not give credit or commits outright theft.?
and im talking about the servers/ forums distributing stolen plugins.

Go read Hume... for his analysis of "causality"
and certainly check out my server. .which i cannot give a direct link for because advertising is banned....

Thanks for the information, if you have a fix and are willing to share it and are worried about people stealing code you're welcome to dm me and discuss further, if I implemented any fix I didn't create myself I always provide credit. Any help acclimating to another developers code is welcome as I haven't had a chance to give it a proper look over. Understandable if you aren't comfortable sharing though.

pookins

Thank you for your hard work , I have been using it since its release (June 2015) and had some interesting arguments regarding stacking , I can remember being very annoying to Canopysheep when I (wrongly) blamed him for reducing the  stacking certain items when it was actually a "hard wired" change by FP, I do find now that some weapons will stack (M249, AK, L96) but Rocket launchers will not. I would say its 85% working and can put up with any problems till its fixed,

Glad to hear you're still using it and that it's still working well, thanks for the extra info!

razorfishsl

Time tripping back into the past 6 years, is fine  for any servers running 6 year old code.
and yes you handed it off to someone else to manage.

But the discussion is that it was working "fine with no problems" 2 versions ago...
To which I called bullshit, by person or persons who clearly did not do a code analysis..
Why is this important?
Becasue it gives the false impression that it is easily fixable.

Like a user who logs into a web app & looks at the menu screen ,then later logs back in after an update, starts really using the app and declares "it was working fine the last time i logged in"

and pookins....
go find my test server on battlemetrics.com... , and stop trying to misdirect, you aint very good at it.
AS for judging ....it's like if i go to a guy that claims to be a mechanic..
and he says shit that is clearly not factual and can be disproved with the simplest of logical Analitical tests.
you know those pesky "test cases" they make you write for breaking software..

Even looking at the code you can CLEARLY see it will not stack correctly...

So when a statment is made that can be disproved with the absolute simplest of tests, then we can say that is bullshit.
I will say again that you appear to lack the insight to celarly analise what is going on or if the code is functioning correctly, or maybe you are some super genius that operates on a level beyound the relms of physics & logic?

as regrds my code...  Why should I put it into a community where some members rip off  & do not give credit or commits outright theft.?
and im talking about the servers/ forums distributing stolen plugins.

Go read Hume... for his analysis of "causality"
and certainly check out my server. .which i cannot give a direct link for because advertising is banned....

You would have to be even more of a complete idiot than i originally thought if  you think servers are running on six year old code , I wont bother with your battlemetrics server as i have no interest in it at all, i dont have to be a "coder" as i dont need to be, you dont have to be a mechanic to drive a car or a builder to live in a house, you are using a finished product, if that product develops faults you have the choice of using it and waiting till it can be fixed or you use something else, you say you have a plugin that works , well use it . I have no interest in reading any more of your whining so will ignore any future posts you make, I have used this plugin since 2015 and will patiently wait for the dev(s) to fix it at his/their discretion.