Zombie Horde NPC note showing in kills.Suggestion

There are new NPC types that are being created by other plugins like Zombie Horde. Zombies still work aka scarecrow but Zombie Horde does not as you can see here.

other things that might help. Killyou has menchend on how to get this to work and if I find those post I will update them here.

killyou
killyou

This is all I got I don't know if you need to do this check but if not thin the CombatEntityTypes just need to add ZombieNPC.

                if (entity.GetType().Name == "ZombieNPC")
                {
                    entname = "ZombieNPC";
                }

I would do it my self but the plugin auto-updates with this link

{
  "GunTrap": 6,
  "FlameTurret": 7,
  "AutoTurret": 7,
  "BaseHelicopter": 0,
  "BradleyAPC": 1,
  "BasePlayer": 5,
  "NPCMurderer": 3,
  "CodeLock": 12,
  "Scientist": 4,
  "ScientistNPC": 4,
  "HTNPlayer": 4,
  "NPCAutoTurret": 13,
  "FireBall": 11,
  "scarecrow": 16,
  "ScientistNPCNew": 4,
  "tunneldweller": 17,
  "underwaterdweller": 18,
  "ZombieNPC": 20 //<----???
}

also, I don't know the value of what all the numbers represent.

i too use death notes and would love to having this working again

BgCkmMnACgazCYd.png taco

i too use death notes and would love to having this working again

ya I am using Simple Kill Feed for now. its on Umod and once you kill a zombie it auto detects what it is. from there you just rename it in the config. still love this plugin but what can you do.


Merged post

ok so this is what Killyou has to say

These 2 if statements need to be switched around so it checks type first
code

ZombieNPC needs to be added to the CombatEntityTypes remote config and the enum in the plugin
code

A case needs to be added to the GetEntityName function so it will display the zombies name


Untested but this will probably work.

I agree, the 2 type and name checks need switched. The ZombieNPC needs added to the CombatEntityType with a value that's not already used on the enum. You also need to add a check in GetCombatEntity function in order to account for this new NPC type. I did the following because it was the fastest way I could patch this but I'm sure someone knows a better method than string comparison (hopefully).

if (entity.GetType().Name.Equals("ZombieNPC"))
return CombatEntityType.ZombieNPC;

JuiceMyOranges

I agree, the 2 type and name checks need switched. The ZombieNPC needs added to the CombatEntityType with a value that's not already used on the enum. You also need to add a check in GetCombatEntity function in order to account for this new NPC type. I did the following because it was the fastest way I could patch this but I'm sure someone knows a better method than string comparison (hopefully).

if (entity.GetType().Name.Equals("ZombieNPC"))
return CombatEntityType.ZombieNPC;

Please download the corrected DeathNotes.cs
Can't figure it out, plugin won't compile